fix: avoid rendering share modal without a session - #13942
Conversation
github-actions
Bot
added
the
external-contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
![oz-for-oss[bot]](https://avatars.githubusercontent.com/in/3450139?s=60&v=4){kind=small}
There was a problem hiding this comment.
Overview
This PR prevents the pane group from marking the share-block modal open until it has confirmed that the terminal session still exists, and quiets the render-time fallback log for stale modal/model races.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed hunks.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
seemeroland
left a comment
seemeroland
left a comment
There was a problem hiding this comment.
This change looks good, but I would be surprised if this resolves the problem. I suspect there's some other case we're rendering the modal when we shouldn't
|
@seemeroland agreed, there's other issues as well (check my other PRs) but I started small since my PRs typically stall here. |
Co-Authored-By: Oz <oz-agent@warp.dev>
Co-Authored-By: Oz <oz-agent@warp.dev>
|
/oz-review |
|
I'm re-reviewing this pull request in response to a review request. You can view the conversation on Warp. I reviewed this pull request and requested human review from: Comment Powered by Oz |
There was a problem hiding this comment.
Overview
This PR prevents the share-block modal from being marked open when the terminal session cannot be resolved, and it clears stale share-modal state before close-pane early returns. It also adds a regression test for the last-pane close path.
Concerns
- No blocking correctness, security, or spec-drift concerns found in the reviewed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
2 participants
Description
Fixes a share-modal lifecycle bug where the pane group could mark the modal open before confirming the terminal session existed. That left a modal with no model mounted, causing repeated render-time warnings and unnecessary repaint/logging work.
Linked Issue
ready-to-specorready-to-implement.Testing
cargo nextest run -p warp -E "test(share_block_modal)"cargo clippy -p warp --lib --tests -- -D warningscargo fmt --allgit diff --checkThis is a lifecycle/performance fix with no visual UI change, so screenshots are not applicable.
Changelog
CHANGELOG-BUG-FIX: Avoid repeated share-modal rendering when no terminal session is available.